chore: separate actions from the controller service#203
Merged
arturaslcast merged 3 commits intomainfrom Dec 29, 2025
Merged
Conversation
Tsonov
reviewed
Dec 29, 2025
| } | ||
|
|
||
| func (h ActionHandlers) Close() error { | ||
| return h[reflect.TypeOf(&castai.ActionCreateEvent{})].(*CreateEventHandler).Close() |
Contributor
Author
There was a problem hiding this comment.
not really when used with the constructor, but this is mostly copy & paste from the existing place
Contributor
There was a problem hiding this comment.
ok, maybe we should make it not panic even in this case, minor change
Tsonov
reviewed
Dec 29, 2025
| for k := range s.actionHandlers { | ||
| s.actionHandlers[k] = handler | ||
| testActionHandlers := map[reflect.Type]actions.ActionHandler{ | ||
| reflect.TypeOf(&castai.ActionDeleteNode{}): handler, |
Contributor
There was a problem hiding this comment.
We used to initialize them all with mock handler, correct? Does this mean we only test these 3?
Contributor
Author
There was a problem hiding this comment.
correct, only 3 action types are actually tested here. I'd argue if only fake actions should be used instead as it's mostly to test if the controller implementation works correctly
Tsonov
approved these changes
Dec 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the controller constructor takes dependencies which are only used to initialize the default actions even if those are not used anywhere else in the implementation. Extract the actions to simplify the controller constructor and inject them instead.